-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the init container settings for Reaper #1290
Conversation
e1bca5d
to
e576484
Compare
0502834
to
c61cde4
Compare
Dockerfile
Outdated
@@ -1,5 +1,5 @@ | |||
# Build the manager binary | |||
FROM golang:1.20 as builder | |||
FROM golang:1.22 as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still 1.22 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I just reverted this change and upgraded Reaper to 3.6.0 which was just released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the Dockerfile change, everything looks fine.
Quality Gate failedFailed conditions |
What this PR does:
Which issue(s) this PR fixes:
Checklist