Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the init container settings for Reaper #1290

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

adejanovski
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@adejanovski adejanovski requested a review from a team as a code owner April 18, 2024 08:14
@adejanovski adejanovski force-pushed the fix/fix-failing-build branch from e1bca5d to e576484 Compare April 18, 2024 08:17
@adejanovski adejanovski force-pushed the fix/fix-failing-build branch from 0502834 to c61cde4 Compare April 18, 2024 08:49
Dockerfile Outdated
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.20 as builder
FROM golang:1.22 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 1.22 here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I just reverted this change and upgraded Reaper to 3.6.0 which was just released

Copy link
Contributor

@burmanm burmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the Dockerfile change, everything looks fine.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@adejanovski adejanovski merged commit ad111fd into main Apr 18, 2024
57 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants